Skip to content

fix: Small CSS issues introduced in recent PRs #7972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025

Conversation

MatiPl01
Copy link
Member

@MatiPl01 MatiPl01 commented Aug 1, 2025

Summary

This PR fixes 2 issues:

  1. Release build failing because of the missing implementation of the isValidColorString method - I mistakenly put it within the #ifdef DEBUG block
  2. Error thrown during the app development on hot reloads when the new code was added in the app - caused by the check if interpolators for the specific component have already been registered. I just removed this check as it is unlikely that someone registers different interpolators for the view with the same name and I don't know if there is a better solution to fix the hot reloads issue.

@MatiPl01 MatiPl01 self-assigned this Aug 1, 2025
@MatiPl01 MatiPl01 requested a review from tjzel August 1, 2025 09:52
@MatiPl01 MatiPl01 added this pull request to the merge queue Aug 1, 2025
Merged via the queue into main with commit 87dee19 Aug 1, 2025
18 checks passed
@MatiPl01 MatiPl01 deleted the @matipl01/css-issue-fixes branch August 1, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants