(cherry-pick) fix: CSS animations not being removed from the stylesheet on web #7952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary @m-bert noticed that animations aren't cleaned up from the Reanimated's CSS stylesheet when components are unmounted. As a result, we ended up having multiple instances of animations that were no longer used. ## Example recording ### Before <video src="https://github.com/user-attachments/assets/9e7d9987-80eb-44b0-8519-ee5a2978f2b0"></video> ### After <video src="https://github.com/user-attachments/assets/cb52aaca-7dab-4dfb-bd0a-98fe7e90a09a"></video> ### Test example <details> <summary>Code snippet</summary> ```tsx import { useState } from 'react'; import { Button } from 'react-native'; import Animated from 'react-native-reanimated'; export default function App() { const [show, setShow] = useState(false); return ( <> <Button title="Show" onPress={() => setShow(!show)} /> {show && ( <Animated.View style={{ backgroundColor: 'green', flex: 1, animationName: { from: { backgroundColor: 'red' }, to: { backgroundColor: 'blue' }, }, animationDuration: '1s', animationTimingFunction: 'ease-in-out', animationDelay: '0s', animationIterationCount: 'infinite', animationDirection: 'alternate', animationFillMode: 'forwards', animationPlayState: 'running', }} /> )} </> ); } ``` </details>
m-bert
approved these changes
Jul 31, 2025
MatiPl01
deleted the
@matipl01/cherry-pick/fix-css-animations-not-cleaned-up
branch
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of the #7932