cherry-pick: Layout animations with rotation not working in RN 0.79 #7400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary This PR fixes issues with rotation transformation after RN upgrade to 0.79. Rotation strings without units are no longer supported so the `rad` unit must me specified explicitly for them to work. ## Example recordings ### ZoomInRotate / ZoomOutRotate | Before | After | |-|-| | <video src="https://github.com/user-attachments/assets/93e0fbdc-519c-4b69-b710-045be29a991c" /> | <video src="https://github.com/user-attachments/assets/6752842f-8e07-4fb9-831a-33c0978a92bf" /> | ### PinwheelIn / PinwheelOut | Before | After | |-|-| | <video src="https://github.com/user-attachments/assets/cb43cbb3-bb54-4a46-8014-22f0db3ba58d" /> | <video src="https://github.com/user-attachments/assets/dc45f65f-cc93-41a3-b4a9-b0e06e75143c" /> | <details> <summary>Code snippet</summary> ```tsx import React, { useState } from 'react'; import { Button, StyleSheet, View } from 'react-native'; import Animated, { PinwheelIn, PinwheelOut } from 'react-native-reanimated'; export default function DeleteAncestorOfExiting() { const [shown, setShown] = useState(true); return ( <View style={styles.container}> <Button onPress={() => { setShown(!shown); }} title="Toggle" /> {shown && ( <Animated.View style={styles.box} exiting={PinwheelOut} entering={PinwheelIn} /> )} </View> ); } const styles = StyleSheet.create({ container: { flex: 1, alignItems: 'center', marginTop: 300, }, box: { width: 100, height: 100, backgroundColor: 'red', }, }); ``` </details>
tjzel
approved these changes
Apr 15, 2025
MatiPl01
deleted the
@matipl01/cherry-pick/fix-layout-animations-with-rotation
branch
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
## Summary This PR adds missing `3.17.3` version and the new `3.17.4` version to compatibility tables in docs. I decided to mark only `3.17.4` as supporting RN 0.79 because of the issue with some layout animations using rotation values without units which stopped working on RN 0.79. Here is a PR with the fix: #7400 ## Example recordings https://github.com/user-attachments/assets/8d83fccf-3413-4384-95e6-f95ec375c3d3 https://github.com/user-attachments/assets/96893a75-3f2d-4dff-b314-8f6acb02553d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR cherry-picks #7347