Skip to content

Bump react-native-is-edge-to-edge to 1.1.7 #7346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zoontek
Copy link
Contributor

@zoontek zoontek commented Apr 4, 2025

Summary

This PR unfixes the current react-native-is-edge-to-edge version.

The current version has peerDependencies that prevents the Expo team from creating a canary release:

Conflicting peer dependency: [email protected]

npm installs this version to respect the >=0.73.0 requirement, even if [email protected] is already a project dependency.

PS: I'm on my phone and without a computer access, if someone can run yarn and fix the pipeline before merging, it would help 🙏

Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for @bartlomiejbloniarz's approval

@tomekzaw tomekzaw changed the title Unfix react-native-is-edge-to-edge version Bump react-native-is-edge-to-edge to 1.1.7 Apr 7, 2025
@tomekzaw tomekzaw added this pull request to the merge queue Apr 7, 2025
Merged via the queue into software-mansion:main with commit 2596b9a Apr 7, 2025
10 checks passed
patrycjakalinska pushed a commit that referenced this pull request Apr 7, 2025
<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->

This PR unfixes the current `react-native-is-edge-to-edge` version.

The current version has `peerDependencies` that prevents the Expo team
from creating a canary release:

```
Conflicting peer dependency: [email protected]
```

npm installs this version to respect the `>=0.73.0` requirement, even if
`[email protected]` is already a project dependency.

PS: I'm on my phone and without a computer access, if someone can run
yarn and fix the pipeline before merging, it would help 🙏

---------

Co-authored-by: Tomek Zawadzki <[email protected]>
patrycjakalinska added a commit that referenced this pull request Apr 7, 2025
This PR unfixes the current `react-native-is-edge-to-edge` version.

The current version has `peerDependencies` that prevents the Expo team
from creating a canary release:

```
Conflicting peer dependency: [email protected]
```

npm installs this version to respect the `>=0.73.0` requirement, even if
`[email protected]` is already a project dependency.

PS: I'm on my phone and without a computer access, if someone can run
yarn and fix the pipeline before merging, it would help 🙏

Co-authored-by: Mathieu Acthernoene <[email protected]>
Co-authored-by: Tomek Zawadzki <[email protected]>
@patrycjakalinska patrycjakalinska mentioned this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants