Skip to content

feat: Add processing for array color related props #7321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

patrycjakalinska
Copy link
Contributor

@patrycjakalinska patrycjakalinska commented Mar 28, 2025

Summary

I've added processing of array and color-related props so every item would be processed.

Test plan

Use code provided with an issue #7282

@patrycjakalinska patrycjakalinska changed the title add color fix: Add colors to processColor list Mar 28, 2025
@patrycjakalinska patrycjakalinska marked this pull request as ready for review March 28, 2025 11:12
Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me, but colors sounds like a custom property so perhaps the developer should call processColor from react-native-reanimated manually.

@patrycjakalinska patrycjakalinska changed the title fix: Add colors to processColor list feat: Add processing for array color related props Mar 31, 2025
@patrycjakalinska patrycjakalinska added this pull request to the merge queue Apr 1, 2025
Merged via the queue into main with commit 04a61b0 Apr 1, 2025
9 checks passed
@patrycjakalinska patrycjakalinska deleted the @patrycjakalinska/colors-prop-to-preprocess-list branch April 1, 2025 05:40
patrycjakalinska added a commit that referenced this pull request Apr 7, 2025
## Summary

I've added processing of array and color-related props so every item
would be processed.

## Test plan

Use code provided with an issue #7282
@patrycjakalinska patrycjakalinska mentioned this pull request Apr 7, 2025
patrycjakalinska added a commit that referenced this pull request Apr 8, 2025
Release of Reanimated 3.17.3

## Summary

Highlights:

* [Bump react-native-is-edge-to-edge to
1.1.7](2596b9a)
* [fix: boxShadow sometimes not working for
web](c2312ed)
* [feat: Add processing for array color related
props](#7321)

## Test plan

Tested our app on different platforms, and modes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants