Cherry pick #7292 #7319
Merged
Cherry pick #7292 #7319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary In RN 0.77 a [batching mechanism for commands was introduced](facebook/react-native@6f1c2a5) behind a feature flag. It was enabled in RN 0.77, but mistakenly disabled in RN 0.78. Now, in RN 0.79 it is back. The mechanism makes it so that our `scrollTo` calls are only applied from `RuntimeSecheduler_Modern::updateRendering` on event loop tick. So when there was nothing happening on the JS thread, our updates wouldn't be propagated to the platform (That's why adding a console.log to each frame would fix scrolling in the repro). To fix that we bypass batching, by calling `schedulerDidDispatchCommand` directly on the `SchedulerDelegate`. This issue is a different thing that the one reported in #6999 by @MatiPl01. It is most probably what @hirbod reported under the same issue. ## Test plan <details> <summary> Code snippet </summary> ```jsx import { StyleSheet, Text } from 'react-native'; import Animated, { scrollTo, useAnimatedRef, useAnimatedStyle, useFrameCallback, useSharedValue, withRepeat, withSequence, withTiming, } from 'react-native-reanimated'; const COUNT = 200; export default function PlaygroundExample() { const animatedRef = useAnimatedRef<Animated.ScrollView>(); const sv = useSharedValue(0); useFrameCallback(() => { sv.value++; scrollTo(animatedRef, 0, sv.value, false); }); return ( <Animated.ScrollView ref={animatedRef}> {Array.from({ length: COUNT }, (_, index) => ( <Item color={`hsl(210, 80%, ${COUNT - index}%)`} name={`Item ${index + 1}`} key={index} /> ))} </Animated.ScrollView> ); } function Item({ color, name }: { name: string; color: string }) { const animatedStyle = useAnimatedStyle(() => { return { transform: [ { translateX: withRepeat( withSequence(withTiming(100), withTiming(0)), -1, true ), }, ], }; }); return ( <Animated.View style={[styles.item, animatedStyle, { backgroundColor: color }]}> <Text style={styles.text}>{name}</Text> </Animated.View> ); } const styles = StyleSheet.create({ item: { alignItems: 'center', justifyContent: 'center', backgroundColor: 'red', height: 100, }, text: { fontWeight: 'bold', }, }); ```
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cherry pick #7292
Test plan