chore(Reanimated3): cherry-pick #7269 #7314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary In current implementation calling `cancelAnimation` on Web results in an error since it invokes `runOnUI`. ## Test plan - [x] Test in in WebExample
There was a problem hiding this comment.
Pull Request Overview
This PR cherry-picks changes from #7269 to address errors on Web when calling cancelAnimation by introducing separate implementations for native and web platforms.
- Split cancelAnimation into two implementations: cancelAnimationNative for native and cancelAnimationWeb for web
- Export cancelAnimation as a constant that selects the appropriate implementation based on the platform flag
Comments suppressed due to low confidence (2)
packages/react-native-reanimated/src/animation/util.ts:577
- Verify that the self-assignment in cancelAnimationWeb reliably cancels the animation on Web; consider adding an inline comment to explain this non-obvious technique.
sharedValue.value = sharedValue.value; // eslint-disable-line no-self-assign
packages/react-native-reanimated/src/animation/util.ts:588
- [nitpick] Consider renaming the constant 'SHOULD_BE_USE_WEB' to a more descriptive name such as 'isWebPlatform' to clearly indicate its purpose as a platform check.
export const cancelAnimation = SHOULD_BE_USE_WEB
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In current implementation calling
cancelAnimationon Web results in an error since it invokesrunOnUI.Test plan