chore(Reanimated3):cherry-pick #7197 #7235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
approved these changes
Mar 13, 2025
tjzel
force-pushed
the
@tjzel/reanimated3/cherry-pick-7197
branch
from
f246376 to
78ec0e0
Compare
When React Native is reloaded when `WorkletsModule.installTurboModule()` wasn't called yet we tried to invoke `invalidateCpp()` which resulted in a nullptr exception, because hybrid data wasn't yet initialized. I applied similar safety mechanism to all relevant code, turns out it narrowed down only to `NativeProxy.java`. See that App no longer crashes on `invalidateCpp()` on a double reload on Android.
tjzel
force-pushed
the
@tjzel/reanimated3/cherry-pick-7197
branch
from
78ec0e0 to
8ed7285
Compare
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cherry picking #7197
Test plan
TBA