Skip to content

feat: make Reanimated depend on Worklets #7087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 5 additions & 22 deletions .github/workflows/example-android-build-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ on:
- .github/workflows/example-android-build-check.yml
- packages/react-native-reanimated/android/**
- packages/react-native-reanimated/Common/**
- packages/react-native-worklets/**
- packages/react-native-worklets/android/**
- packages/react-native-worklets/Common/**
- apps/fabric-example/package.json
- apps/fabric-example/android/**
merge_group:
Expand All @@ -20,21 +21,12 @@ on:
- .github/workflows/example-android-build-check.yml
- packages/react-native-reanimated/android/**
- packages/react-native-reanimated/Common/**
- packages/react-native-worklets/**
- packages/react-native-worklets/android/**
- packages/react-native-worklets/Common/**
- apps/fabric-example/package.json
- apps/fabric-example/android/**
workflow_call:
inputs:
use-external-worklets:
required: false
type: boolean
default: false
workflow_dispatch:
inputs:
use-external-worklets:
required: false
type: boolean
default: false

jobs:
build:
Expand All @@ -45,7 +37,7 @@ jobs:
COMMON_APP_DIR: apps/common-app
REANIMATED_DIR: packages/react-native-reanimated
concurrency:
group: android-${{ github.ref }}-${{ inputs.use-external-worklets }}
group: android-${{ github.ref }}
cancel-in-progress: true
steps:
- name: Check out Git repository
Expand All @@ -64,15 +56,6 @@ jobs:
working-directory: ${{ env.REANIMATED_DIR }}
run: yarn build

- name: Use external worklets
if: ${{ inputs.use-external-worklets }}
working-directory: ${{ env.COMMON_APP_DIR }}
run: yarn add react-native-worklets@workspace:"*"
- name: Use external worklets
if: ${{ inputs.use-external-worklets }}
working-directory: ${{ env.WORKING_DIRECTORY }}
run: yarn add react-native-worklets@workspace:"*"

- name: Build app
working-directory: ${{ env.WORKING_DIRECTORY }}/android
run: ./gradlew assembleDebug --build-cache -PreactNativeArchitectures=arm64-v8a
31 changes: 9 additions & 22 deletions .github/workflows/example-ios-build-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ on:
- packages/react-native-reanimated/scripts/reanimated_utils.rb
- packages/react-native-reanimated/apple/**
- packages/react-native-reanimated/Common/**
- packages/react-native-worklets/**
- packages/react-native-worklets/RNWorklets.podspec
- packages/react-native-worklets/scripts/worklets_utils.rb
- packages/react-native-worklets/android/**
- packages/react-native-worklets/Common/**
- apps/fabric-example/package.json
- apps/fabric-example/ios/**
merge_group:
Expand All @@ -24,21 +27,14 @@ on:
- packages/react-native-reanimated/scripts/reanimated_utils.rb
- packages/react-native-reanimated/apple/**
- packages/react-native-reanimated/Common/**
- packages/react-native-worklets/**
- packages/react-native-worklets/RNWorklets.podspec
- packages/react-native-worklets/scripts/worklets_utils.rb
- packages/react-native-worklets/android/**
- packages/react-native-worklets/Common/**
- apps/fabric-example/package.json
- apps/fabric-example/ios/**
workflow_call:
inputs:
use-external-worklets:
required: false
type: boolean
default: false
workflow_dispatch:
inputs:
use-external-worklets:
required: false
type: boolean
default: false

jobs:
build:
Expand All @@ -49,7 +45,7 @@ jobs:
COMMON_APP_DIR: apps/common-app
REANIMATED_DIR: packages/react-native-reanimated
concurrency:
group: ios-${{ github.ref }}-${{ inputs.use-external-worklets }}
group: ios-${{ github.ref }}
cancel-in-progress: true
steps:
- name: Check out Git repository
Expand All @@ -65,15 +61,6 @@ jobs:
working-directory: ${{ env.REANIMATED_DIR }}
run: yarn build

- name: Use external worklets
if: ${{ inputs.use-external-worklets }}
working-directory: ${{ env.COMMON_APP_DIR }}
run: yarn add react-native-worklets@workspace:"*"
- name: Use external worklets
if: ${{ inputs.use-external-worklets }}
working-directory: ${{ env.WORKING_DIRECTORY }}
run: yarn add react-native-worklets@workspace:"*"

# TODO: Add caching for node_modules and artifacts that will work with monorepo setup.
- name: Install Pods
working-directory: ${{ env.WORKING_DIRECTORY }}/ios
Expand Down
31 changes: 9 additions & 22 deletions .github/workflows/example-macos-build-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ on:
- packages/react-native-reanimated/scripts/reanimated_utils.rb
- packages/react-native-reanimated/apple/**
- packages/react-native-reanimated/Common/**
- packages/react-native-worklets/**
- packages/react-native-worklets/RNWorklets.podspec
- packages/react-native-worklets/scripts/worklets_utils.rb
- packages/react-native-worklets/android/**
- packages/react-native-worklets/Common/**
- apps/macos-example/package.json
- apps/macos-example/ios/**
- apps/macos-example/macos/**
Expand All @@ -25,22 +28,15 @@ on:
- packages/react-native-reanimated/scripts/reanimated_utils.rb
- packages/react-native-reanimated/apple/**
- packages/react-native-reanimated/Common/**
- packages/react-native-worklets/**
- packages/react-native-worklets/RNWorklets.podspec
- packages/react-native-worklets/scripts/worklets_utils.rb
- packages/react-native-worklets/android/**
- packages/react-native-worklets/Common/**
- apps/macos-example/package.json
- apps/macos-example/ios/**
- apps/macos-example/macos/**
workflow_call:
inputs:
use-external-worklets:
required: false
type: boolean
default: false
workflow_dispatch:
inputs:
use-external-worklets:
required: false
type: boolean
default: false

jobs:
build:
Expand All @@ -51,7 +47,7 @@ jobs:
COMMON_APP_DIR: apps/common-app
REANIMATED_DIR: packages/react-native-reanimated
concurrency:
group: macos-${{ github.ref }}-${{ inputs.use-external-worklets }}
group: macos-${{ github.ref }}
cancel-in-progress: true
steps:
- name: Check out Git repository
Expand All @@ -68,15 +64,6 @@ jobs:
working-directory: ${{ env.REANIMATED_DIR }}
run: yarn build

- name: Use external worklets
if: ${{ inputs.use-external-worklets }}
working-directory: ${{ env.COMMON_APP_DIR }}
run: yarn add react-native-worklets@workspace:"*"
- name: Use external worklets
if: ${{ inputs.use-external-worklets }}
working-directory: ${{ env.WORKING_DIRECTORY }}
run: yarn add react-native-worklets@workspace:"*"

- name: Install Pods
working-directory: ${{ env.WORKING_DIRECTORY }}/macos
run: |
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/example-next-build-check-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,14 @@ on:
paths:
- .github/workflows/example-next-build-check-and-test.yml
- 'packages/react-native-reanimated/src/**'
- 'packages/react-native-reanimated/NextExample/**'
- 'packages/react-native-worklets/src/**'
- 'apps/next-example/**'
push:
branches:
- main
workflow_call:
workflow_dispatch:

jobs:
check:
runs-on: ubuntu-latest
Expand Down
31 changes: 9 additions & 22 deletions .github/workflows/example-tvos-build-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ on:
- packages/react-native-reanimated/scripts/reanimated_utils.rb
- packages/react-native-reanimated/apple/**
- packages/react-native-reanimated/Common/**
- packages/react-native-worklets/**
- packages/react-native-worklets/RNWorklets.podspec
- packages/react-native-worklets/scripts/worklets_utils.rb
- packages/react-native-worklets/android/**
- packages/react-native-worklets/Common/**
merge_group:
branches:
- main
Expand All @@ -22,19 +25,12 @@ on:
- packages/react-native-reanimated/scripts/reanimated_utils.rb
- packages/react-native-reanimated/apple/**
- packages/react-native-reanimated/Common/**
- packages/react-native-worklets/**
- packages/react-native-worklets/RNWorklets.podspec
- packages/react-native-worklets/scripts/worklets_utils.rb
- packages/react-native-worklets/android/**
- packages/react-native-worklets/Common/**
workflow_call:
inputs:
use-external-worklets:
required: false
type: boolean
default: false
workflow_dispatch:
inputs:
use-external-worklets:
required: false
type: boolean
default: false

jobs:
build:
Expand All @@ -45,7 +41,7 @@ jobs:
COMMON_APP_DIR: apps/common-app
REANIMATED_DIR: packages/react-native-reanimated
concurrency:
group: tvos-${{ github.ref }}-${{ inputs.use-external-worklets }}
group: tvos-${{ github.ref }}
cancel-in-progress: true
steps:
- name: Check out Git repository
Expand All @@ -61,15 +57,6 @@ jobs:
working-directory: ${{ env.REANIMATED_DIR }}
run: yarn build

- name: Use external worklets
if: ${{ inputs.use-external-worklets }}
working-directory: ${{ env.COMMON_APP_DIR }}
run: yarn add react-native-worklets@workspace:"*"
- name: Use external worklets
if: ${{ inputs.use-external-worklets }}
working-directory: ${{ env.WORKING_DIRECTORY }}
run: yarn add react-native-worklets@workspace:"*"

- name: Install Pods
working-directory: ${{ env.WORKING_DIRECTORY }}/ios
run: |
Expand Down

This file was deleted.

This file was deleted.

32 changes: 1 addition & 31 deletions apps/common-app/index.ts
Original file line number Diff line number Diff line change
@@ -1,34 +1,4 @@
/* eslint-disable no-var */
/* eslint-disable no-inner-declarations */
/* eslint-disable @typescript-eslint/no-unsafe-member-access */
/* eslint-disable @typescript-eslint/no-var-requires */
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
/* eslint-disable no-underscore-dangle */

// This detection mechanism is necessary for the time being for dynamic
// resolution of worklets. `react-native-worklets` is present in monorepo's
// node_modules therefore allowed to be imported though it's not a dependency.
let hasExternalWorklets = false;
try {
const packageJson = require('./package.json') as Record<
string,
Record<string, unknown>
>;
hasExternalWorklets =
packageJson?.dependencies?.['react-native-worklets'] !== undefined ||
packageJson?.devDependencies?.['react-native-worklets'] !== undefined;
} catch (_e) {
// Do nothing.
}

declare global {
var __DISALLOW_WORKLETS_IMPORT: boolean | undefined;
}

globalThis.__DISALLOW_WORKLETS_IMPORT = !hasExternalWorklets;

// Has to be imported dynamically to inject __DISALLOW_WORKLETS_IMPORT before
// any other code is executed.
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-var-requires, @typescript-eslint/no-unsafe-member-access
const App = require('@/App').default;

export default App;
1 change: 1 addition & 0 deletions apps/common-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"react-native-safe-area-context": "5.1.0",
"react-native-screens": "4.5.0",
"react-native-svg": "15.11.1",
"react-native-worklets": "workspace:*",
"react-strict-dom": "0.0.27"
},
"devDependencies": {
Expand Down
Loading
Loading