refactor: RN$Bridgeless as isFabric #7043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
approved these changes
Feb 20, 2025
piaskowyk
approved these changes
Feb 20, 2025
8 tasks
kkafar
pushed a commit
to software-mansion/react-native-screens
that referenced
this pull request
Feb 20, 2025
## Description Since 0.74 `RN$Bridgeless` is always defined in the global object and bridgeless mode isn't supported anymore. Therefore checking `RN$Bridgeless` for Fabric is safer than depending on `_IS_FABRIC` variable which we intend to remove in the future. `RN$Bridgeless` is added to `global` much faster than `_IS_FABRIC`. See software-mansion/react-native-reanimated#7043 ## Changes 👍 ## Screenshots / GIFs :shipit: ## Test code and steps to reproduce 🚀 ## Checklist - [x] Included code example that can be used to test this change - [x] Updated TS types - [x] Updated documentation: <!-- For adding new props to native-stack --> - [x] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [x] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [x] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [x] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since Bridgeless by default
RN$Bridgelessglobal property is injected before any library code is executed. We don't support "Bridgeful" mode anymore so we can depend on this variable to detect the architecture.Test plan
See that
console.log(globalThis.RN$Bridgeless);yieldstruewhen added in top-level scope of any file.