Fix iOS build with USE_FRAMEWORKS=dynamic
#7025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
approved these changes
Feb 14, 2025
tjzel
pushed a commit
that referenced
this pull request
Feb 17, 2025
## Summary This PR fixes the following iOS build errors reported by @kkafar when `USE_FRAMEWORKS=dynamic` is set:  ``` Undefined symbol: facebook::jsi::dynamicFromValue(facebook::jsi::Runtime&, facebook::jsi::Value const&, std::__1::function<bool (std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&)> const&) ``` This is just the minimal fix, I will remove `install_modules_dependencies_legacy` in an upcoming PR. ## Test plan 1. Add `ENV['USE_FRAMEWORKS'] = 'dynamic'` in `fabric-example/ios/Podfile` 2. Run `bundle install && bundle exec pod install` 3. Open fabric-example in Xcode using `xed ios` 4. Build fabric-example app
tjzel
pushed a commit
that referenced
this pull request
Feb 17, 2025
## Summary This PR fixes the following iOS build errors reported by @kkafar when `USE_FRAMEWORKS=dynamic` is set:  ``` Undefined symbol: facebook::jsi::dynamicFromValue(facebook::jsi::Runtime&, facebook::jsi::Value const&, std::__1::function<bool (std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&)> const&) ``` This is just the minimal fix, I will remove `install_modules_dependencies_legacy` in an upcoming PR. ## Test plan 1. Add `ENV['USE_FRAMEWORKS'] = 'dynamic'` in `fabric-example/ios/Podfile` 2. Run `bundle install && bundle exec pod install` 3. Open fabric-example in Xcode using `xed ios` 4. Build fabric-example app
tomekzaw
added a commit
that referenced
this pull request
Feb 19, 2025
## Summary This PR fixes the following iOS build errors reported by @kkafar when `USE_FRAMEWORKS=dynamic` is set:  ``` Undefined symbol: facebook::jsi::dynamicFromValue(facebook::jsi::Runtime&, facebook::jsi::Value const&, std::__1::function<bool (std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&)> const&) ``` This is just the minimal fix, I will remove `install_modules_dependencies_legacy` in an upcoming PR. ## Test plan 1. Add `ENV['USE_FRAMEWORKS'] = 'dynamic'` in `fabric-example/ios/Podfile` 2. Run `bundle install && bundle exec pod install` 3. Open fabric-example in Xcode using `xed ios` 4. Build fabric-example app
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the following iOS build errors reported by @kkafar when
USE_FRAMEWORKS=dynamicis set:This is just the minimal fix, I will remove
install_modules_dependencies_legacyin an upcoming PR.Test plan
ENV['USE_FRAMEWORKS'] = 'dynamic'infabric-example/ios/Podfilebundle install && bundle exec pod installxed ios