chore: remove apps from node_modules #7003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
approved these changes
Feb 11, 2025
tjzel
added a commit
that referenced
this pull request
Feb 17, 2025
With current monorepo setup `fabric-example` etc. (not counting `common-app`) are linked in `node_modules` so they could be imported in another workspace, which is unnecessary. This doesn't really bother us, but sometimes when you need to find something in `node_modules` it's annoying that these show up. 🚀
tjzel
added a commit
that referenced
this pull request
Feb 17, 2025
With current monorepo setup `fabric-example` etc. (not counting `common-app`) are linked in `node_modules` so they could be imported in another workspace, which is unnecessary. This doesn't really bother us, but sometimes when you need to find something in `node_modules` it's annoying that these show up. 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With current monorepo setup
fabric-exampleetc. (not countingcommon-app) are linked innode_modulesso they could be imported in another workspace, which is unnecessary. This doesn't really bother us, but sometimes when you need to find something innode_modulesit's annoying that these show up.Test plan
🚀