fix: initializer file not loaded in Expo52 #6980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michał Bert <[email protected]>
This was
linked to
issues
Feb 5, 2025
tjzel
added a commit
that referenced
this pull request
Feb 17, 2025
Turns out that `sideEffects` field was ignored and `isWeb()` check evaluated to static false, removing `initializers.ts` from the bundle. Fixes - #6740 - #6839 Tested it on RNGH web example app using Expo52 Co-authored-by: Michał Bert <[email protected]>
tjzel
added a commit
that referenced
this pull request
Feb 18, 2025
Turns out that `sideEffects` field was ignored and `isWeb()` check evaluated to static false, removing `initializers.ts` from the bundle. Fixes - #6740 - #6839 Tested it on RNGH web example app using Expo52 Co-authored-by: Michał Bert <[email protected]>
tjzel
added a commit
that referenced
this pull request
Feb 18, 2025
Turns out that `sideEffects` field was ignored and `isWeb()` check evaluated to static false, removing `initializers.ts` from the bundle. Fixes - #6740 - #6839 Tested it on RNGH web example app using Expo52 Co-authored-by: Michał Bert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Turns out that
sideEffectsfield was ignored andisWeb()check evaluated to static false, removinginitializers.tsfrom the bundle.Fixes
Test plan
Tested it on RNGH web example app using Expo52