refactor: move Worklets JS core from Reanimated #6973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
commented
Feb 3, 2025
packages/react-native-reanimated/src/ReanimatedModule/NativeReanimated.ts
Show resolved
Hide resolved
piaskowyk
reviewed
Feb 6, 2025
piaskowyk
approved these changes
Feb 6, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
## Summary I introduced a regression in #6973 by moving JS implementation of `requestAnimationFrame` to Worklets. Native version of `requestAnimationFrame` is injected in Reanimated's `UIRuntimeDecorator.cpp` so `requestAnimationFrame` must be overwritten in Reanimated, not in Worklets. Since all the native implementation is in Reanimated and it would be a hard task to extract it right now, I decided to keep it for the time being unless we decide where it should land eventually. ## Test plan The only difference is the lack of batching with my regression introduced. You can `console.log(currentCallbacks.length)` to see that the batching is restored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently JS core of Worklets sits in Reanimated package. This PR moves it to Worklets. It's a bit messy but we'll get there eventually.
createCustomErrorthat createsWorkletsErrorandReanimatedErrorused in respective packages.use-worklets-error, a copypaste ofuse-reanimated-error.shareables.tstoreact-native-worklets.threads.tstoreact-native-worklets.initializers.tstoreact-native-workletsruntimes.tstoreact-native-workletsTest plan
CI, run the example app.