Add Keyframe animation caching #6960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
approved these changes
Jan 30, 2025
bartlomiejbloniarz
deleted the
@bartlomiejbloniarz/fix-keyframe-easing
branch
tjzel
pushed a commit
that referenced
this pull request
Feb 17, 2025
## Summary Our current implementation of keyframe parsing mutates the keyframe definition object (e.g. we remove the easing function). If we try to call `build()` on a `Keyframe` object more than once, we will end up with a different animation after the first time. This is bad because we want people to memoize their Keyframes. I decided to fix this problem by caching the calculated animation. This fixes this problem, and also allows us to reuse the result of parsing. ## Test plan
tjzel
pushed a commit
that referenced
this pull request
Feb 17, 2025
## Summary Our current implementation of keyframe parsing mutates the keyframe definition object (e.g. we remove the easing function). If we try to call `build()` on a `Keyframe` object more than once, we will end up with a different animation after the first time. This is bad because we want people to memoize their Keyframes. I decided to fix this problem by caching the calculated animation. This fixes this problem, and also allows us to reuse the result of parsing. ## Test plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our current implementation of keyframe parsing mutates the keyframe definition object (e.g. we remove the easing function). If we try to call
build()on aKeyframeobject more than once, we will end up with a different animation after the first time. This is bad because we want people to memoize their Keyframes. I decided to fix this problem by caching the calculated animation. This fixes this problem, and also allows us to reuse the result of parsing.Test plan