Improve readability of HEADER_SEARCH_PATHS in podspecs
#6949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
approved these changes
Jan 28, 2025
tjzel
pushed a commit
that referenced
this pull request
Feb 17, 2025
## Summary
This PR improves readability of `HEADER_SEARCH_PATHS` value in
RNReanimated.podspec and RNWorklets.podspec by passing all flags as an
array of strings and calling `.join(' ')` at the end.
## Test plan
tjzel
pushed a commit
that referenced
this pull request
Feb 17, 2025
## Summary
This PR improves readability of `HEADER_SEARCH_PATHS` value in
RNReanimated.podspec and RNWorklets.podspec by passing all flags as an
array of strings and calling `.join(' ')` at the end.
## Test plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves readability of
HEADER_SEARCH_PATHSvalue in RNReanimated.podspec and RNWorklets.podspec by passing all flags as an array of strings and calling.join(' ')at the end.Test plan