Fix JS_RUNTIME_HERMES flag definition
#6838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
approved these changes
Dec 19, 2024
packages/react-native-reanimated/Common/cpp/worklets/Tools/defs.h
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/worklets/WorkletRuntime/ReanimatedHermesRuntime.cpp
Show resolved
Hide resolved
piaskowyk
added
the
Check compatibility
|
I've also tested it with JSC, and it works properly 👍 |
tjzel
approved these changes
Dec 23, 2024
packages/react-native-reanimated/Common/cpp/worklets/Tools/defs.h
Outdated
Show resolved
Hide resolved
tjzel
pushed a commit
that referenced
this pull request
Feb 17, 2025
## Summary This PR streamlines the definition of the `JS_RUNTIME_HERMES` flag. Previously, the flag wasn't consistently defined across all usage points (which prevented the compilation of certain branches of code - for example in WorkletsModuleProxy.cpp), and it also had duplicated definitions. Additionally, I've removed outdated and unnecessary checks from the flag definition. ## Test plan
tjzel
pushed a commit
that referenced
this pull request
Feb 17, 2025
## Summary This PR streamlines the definition of the `JS_RUNTIME_HERMES` flag. Previously, the flag wasn't consistently defined across all usage points (which prevented the compilation of certain branches of code - for example in WorkletsModuleProxy.cpp), and it also had duplicated definitions. Additionally, I've removed outdated and unnecessary checks from the flag definition. ## Test plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR streamlines the definition of the
JS_RUNTIME_HERMESflag. Previously, the flag wasn't consistently defined across all usage points (which prevented the compilation of certain branches of code - for example in WorkletsModuleProxy.cpp), and it also had duplicated definitions. Additionally, I've removed outdated and unnecessary checks from the flag definition.Test plan