chore: Align with [email protected] as oldest supported version #6629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
force-pushed
the
@tjzel/drop-rn-73
branch
from
91d0846 to
825ce18
Compare
tjzel
added
the
Check compatibility
bartlomiejbloniarz
approved these changes
Oct 30, 2024
tomekzaw
reviewed
Oct 30, 2024
tomekzaw
approved these changes
Oct 30, 2024
1 task
kkafar
added a commit
to software-mansion/react-native-screens
that referenced
this pull request
Jan 23, 2025
## Description
Lint started failing recently for no apparent reason with errors:
```
Run yarn format
RangeError [ERR_CHILD_PROCESS_STDIO_MAXBUFFER]: stdout maxBuffer length exceeded
at new NodeError (node:internal/errors:405:5)
at Socket.onChildStdout (node:child_process:490:14)
at Socket.emit (node:events:517:28)
at addChunk (node:internal/streams/readable:368:12)
at readableAddChunk (node:internal/streams/readable:337:11)
at Readable.push (node:internal/streams/readable:278:10)
at Pipe.onStreamRead (node:internal/stream_base_commons:190:23) {
code: 'ERR_CHILD_PROCESS_STDIO_MAXBUFFER',
cmd: './android/gradlew -p android spotlessApply'
}
```
and
```
Not a number: 33x:
java.lang.NumberFormatException: Not a number: 33x
at com.sun.xml.bind.DatatypeConverterImpl._parseInt(DatatypeConverterImpl.java:95)
at com.sun.xml.bind.v2.model.impl.RuntimeBuiltinLeafInfoImpl$18.parse(RuntimeBuiltinLeafInfoImpl.java:712)
at com.sun.xml.bind.v2.model.impl.RuntimeBuiltinLeafInfoImpl$18.parse(RuntimeBuiltinLeafInfoImpl.java:710)
at com.sun.xml.bind.v2.runtime.unmarshaller.TextLoader.text(TextLoader.java:39)
at com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallingContext.text(UnmarshallingContext.java:560)
at com.sun.xml.bind.v2.runtime.unmarshaller.SAXConnector.processText(SAXConnector.java:183)
...
(much longer stacktrace)
```
Edit: Idk why the issue started happening, but bumping gradle wrapper
version & gradle build tools version resolved the issue.
I've used [versions used in
reanimated](software-mansion/react-native-reanimated#6629),
at the time their last supported version of `react-native` was 0.74 (the
same as it is for us now).
## Test code and steps to reproduce
Lint on CI should not longer fail.
## Checklist
- [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://github.com/facebook/react-native/blob/0.74-stable/gradle/wrapper/gradle-wrapper.properties
https://github.com/facebook/react-native/blob/0.74-stable/packages/react-native/gradle/libs.versions.toml
Test plan