fix: Recursion in worklets #6445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
commented
Aug 23, 2024
apps/common-app/src/examples/RuntimeTests/tests/plugin/recursion.test.tsx
Show resolved
Hide resolved
bartlomiejbloniarz
approved these changes
Aug 28, 2024
tjzel
force-pushed
the
@tjzel/plugin/dont-rename-react-part-of-worklets
branch
from
44f50b7 to
8edc3f0
Compare
This was referenced Sep 24, 2024
This was referenced Oct 3, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Turns out that in #6163 I overlooked the fact that we shouldn't rename React part of worklet functions. This PR changes the naming behavior, only worklet counterparts are renamed for better error verbosity. See differences in snapshots for more details.
Test plan