feat: User-defined logger config #6409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatiPl01
force-pushed
the
@matipl01/configurable-logger
branch
from
d6408fc to
b39d25e
Compare
MatiPl01
force-pushed
the
@matipl01/new-logger-console-logs-replacement
branch
from
386b83a to
fba8f74
Compare
MatiPl01
force-pushed
the
@matipl01/configurable-logger
branch
from
722712a to
2249971
Compare
tjzel
reviewed
Aug 26, 2024
MatiPl01
force-pushed
the
@matipl01/new-logger-console-logs-replacement
branch
from
d5d9145 to
8986ccb
Compare
Base automatically changed from
@matipl01/new-logger-console-logs-replacement
to
main
August 26, 2024 12:02
MatiPl01
force-pushed
the
@matipl01/configurable-logger
branch
from
0e9eec1 to
e4bca1d
Compare
MatiPl01
commented
Aug 27, 2024
tjzel
reviewed
Aug 28, 2024
MatiPl01
force-pushed
the
@matipl01/configurable-logger
branch
from
68d8421 to
af6bba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a possibility to customize log level via the
levelproperty (limit to just see errors or show errors and warnings) and enable/disable strict mode (viastrictproperty), which will be useful for changes implemented in this PR to show invalid.valueaccess warnings only in the strict mode.Example recording
Screen.Recording.2024-08-27.at.20.03.27.mp4
Test plan
EmptyExample(which will be reverted to the original implementation before merging this PR),levelproperty) viaAnimated.configureLogger,