refactor: Less error prone _value in Mutables.
#6311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
force-pushed
the
@tjzel/less-error-prone-_value
branch
from
b27afde to
a2b44cc
Compare
Latropos
reviewed
Aug 19, 2024
tjzel
added a commit
that referenced
this pull request
Aug 28, 2024
## Summary At the moment the `_value` property is an ordinary property, which makes it visible via `Object.keys` or `const prop in sv`. This way sometimes when it's accidentally passed to React it throws errors and we had to add troubleshooting for that. This PR makes it so it would be hidden via `enumerable: false`. ## Test plan - [x] Runtime tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At the moment the
_valueproperty is an ordinary property, which makes it visible viaObject.keysorconst prop in sv. This way sometimes when it's accidentally passed to React it throws errors and we had to add troubleshooting for that.This PR makes it so it would be hidden via
enumerable: false.Test plan