Skip to content

Remove setNextLayoutAnimationGroup call #4955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Remove setNextLayoutAnimationGroup call #4955

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f9608c
Remove `setNextLayoutAnimationGroup` call
tomekzaw Aug 22, 2023
d5ad82d
Use `setValue:forKey:` instead
tomekzaw Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apple/LayoutReanimation/REASwizzledUIManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ - (RCTViewManagerUIBlock)reanimated_uiBlockWithLayoutUpdateForRootView:(RCTRootS
// Clean up
// below line serves as this one uiManager->_layoutAnimationGroup = nil;, because we don't have access to the
// private field
[uiManager setNextLayoutAnimationGroup:nil];
[uiManager setValue:nil forKey:@"_layoutAnimationGroup"];

[originalSelf.animationsManager viewsDidLayout];
// Reanimated changes /end
Expand Down