fix: unplugin-typegpu should parse files with TS syntax support #1516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pkg.pr.new packages benchmark commit |
iwoplaza
changed the title
| @@ -120,6 +120,7 @@ interface Options { | |||
| exclude?: FilterPattern; | |||
| enforce?: 'post' | 'pre' | undefined; | |||
| forceTgpuAlias?: string; | |||
| autoNamingEnabled?: boolean; | |||
There was a problem hiding this comment.
Nice catch. While we're at it, could you include the default options here as well?
This change matters when the bundler gives us raw TypeScript code, instead of stripping the types first before handing it to us. Rolldown did this, and this change makes it possible to use unplugin-typegpu with rolldown/tsdown. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a hidden option in the
this.parseAPI, wherelang: 'ts'has to be passed in, as stated in rolldown/rolldown#5388