feat: std mod #1513
Merged
feat: std mod #1513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pkg.pr.new packages benchmark commit |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
lursz
commented
Jul 18, 2025
lursz
commented
Jul 18, 2025
|
Where do we put the line on which operations have an infix variant? Right now it is only |
Comment on lines
165
to
173
| const createMixedComponentWise2 = <T extends { x: number; y: number }>( | ||
| vecConstructor: (x: number, y: number) => T, | ||
| ) => { | ||
| return (op: BinaryOp) => (a: T | number, b: T | number) => | ||
| vecConstructor( | ||
| op(typeof a === 'number' ? a : a.x, typeof b === 'number' ? b : b.x), | ||
| op(typeof a === 'number' ? a : a.y, typeof b === 'number' ? b : b.y), | ||
| ); | ||
| }; |
There was a problem hiding this comment.
The way this is written makes it usable for two vector operations as well. We could replace binaryComponentWise with this and simplify the ifs in std operators a little. Probably a job for #1336
reczkok
requested changes
Jul 21, 2025
aleksanderkatan
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.