feat: Match up vertex and fragment locations in render pipeline #1377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pkg.pr.new packages benchmark commit |
mhawryluk
changed the title
mhawryluk
changed the title
iwoplaza
requested changes
Jun 23, 2025
apps/typegpu-docs/src/content/examples/simulation/stable-fluid/index.ts
Outdated
Show resolved
Hide resolved
| ).toStrictEqual({ | ||
| a: d.location(5, d.vec4f), | ||
| b: d.location(1, d.vec4f), | ||
| c: d.location(6, d.vec4f), |
There was a problem hiding this comment.
Probably same for vertex in, however our types don't even allow decorated schemas.
| baz2: d.location(5, d.f32), | ||
| baz3: d.u32, | ||
| }, | ||
| })`{}`.$name('vertexMain'); |
There was a problem hiding this comment.
Do we try to generate valid wgsl in these tests? If so, we should always include builtin position in the vertex out and return something in the body
Comment on lines
613
to
616
| console.warn( | ||
| `Mismatched custom location for key: ${key}, using location set on vertex output: ${ | ||
| locations[key] | ||
| }`, |
There was a problem hiding this comment.
I'd include the mismatched location as well.
`Mismatched location between vertexFn output (${locations[key]}) and fragmentFn input (${customLocation}) for key ${key}, using the location set on vertex output.`Maybe we could also include the names of the vertexFn and fragmentFn?
Comment on lines
59
to
73
| if (typeof implementation === 'string') { | ||
| if (!isEntry) { | ||
| addArgTypesToExternals( | ||
| implementation, | ||
| argTypes, | ||
| (externals) => externalsToApply.push(externals), | ||
| ); | ||
| addReturnTypeToExternals( | ||
| implementation, | ||
| returnType, | ||
| (externals) => externalsToApply.push(externals), | ||
| ); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
We could probably do this check in tgpuFn.ts, if we already move the else branch to entry functions
iwoplaza
requested changes
Jun 27, 2025
iwoplaza
reviewed
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #885
closes #1375