Skip to content

feat: explicit name for dualImpl #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 12, 2025
Merged

feat: explicit name for dualImpl #1334

merged 18 commits into from
Jun 12, 2025

Conversation

lursz
Copy link
Contributor

@lursz lursz commented Jun 4, 2025

No description provided.

Copy link

github-actions bot commented Jun 4, 2025

pkg.pr.new

packages

pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@1334
pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@7783cf73b860ccdd20bdb6661dea2c5cbb8d8af1

benchmark
view benchmark

commit
view commit

@lursz lursz linked an issue Jun 4, 2025 that may be closed by this pull request
@lursz lursz force-pushed the feat/explicit-name branch from de1a9e0 to a7a3815 Compare June 11, 2025 09:20
@lursz lursz marked this pull request as ready for review June 11, 2025 09:23
Copy link
Contributor

@aleksanderkatan aleksanderkatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Could you also add somewhere a test like this?

it('names functions created by createDualImpl', () => {
  const dual = createDualImpl(
    (a) => a,
    (snippet) => snippet,
    'myDualImpl',
  );
  expect(getName(dual)).toBe('myDualImpl');
});

Copy link
Contributor

@aleksanderkatan aleksanderkatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥣

Copy link
Contributor

@mhawryluk mhawryluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Contributor

@reczkok reczkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@lursz lursz merged commit 76c4cbf into main Jun 12, 2025
6 checks passed
@lursz lursz deleted the feat/explicit-name branch July 2, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Give every typegpu/std function an explicit name
4 participants