Skip to content

feat(typegpu/std): implement cosh, acosh, exp2 #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 5, 2025
Merged

feat(typegpu/std): implement cosh, acosh, exp2 #1317

merged 14 commits into from
Jun 5, 2025

Conversation

lursz
Copy link
Contributor

@lursz lursz commented May 30, 2025 •
edited
Loading

  • cosh
  • acosh
  • exp2

@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2025 •
edited
Loading

pkg.pr.new

packages

pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@1317
pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@fe674fa5398bd58ee30c17df6513e4270bab46ca

benchmark
view benchmark

commit
view commit

@lursz lursz marked this pull request as ready for review June 2, 2025 13:44
aleksanderkatan
aleksanderkatan approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@aleksanderkatan aleksanderkatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gj!

aleksanderkatan
aleksanderkatan reviewed Jun 4, 2025
View reviewed changes
aleksanderkatan
aleksanderkatan approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@aleksanderkatan aleksanderkatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mhawryluk
mhawryluk approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@mhawryluk mhawryluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🎉

reczkok
reczkok approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@reczkok reczkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

iwoplaza
iwoplaza approved these changes Jun 5, 2025
View reviewed changes
Copy link
Collaborator

@iwoplaza iwoplaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 🚀

@iwoplaza iwoplaza changed the title feat: introduced new trigonometric functions feat(typegpu/std): implement cosh, acosh, exp2 Jun 5, 2025
@iwoplaza iwoplaza merged commit 84a4d9d into main Jun 5, 2025
6 checks passed
@aleksanderkatan aleksanderkatan deleted the feat/std-math-trigo branch June 6, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwoplaza iwoplaza iwoplaza approved these changes

@aleksanderkatan aleksanderkatan aleksanderkatan approved these changes

@reczkok reczkok reczkok approved these changes

@mhawryluk mhawryluk mhawryluk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lursz @iwoplaza @aleksanderkatan @reczkok @mhawryluk