Skip to content

feat: Allow omitting types in wgsl header #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jun 6, 2025
Merged

feat: Allow omitting types in wgsl header #1306

merged 21 commits into from
Jun 6, 2025

Conversation

aleksanderkatan
Copy link
Contributor

No description provided.

@aleksanderkatan aleksanderkatan linked an issue May 27, 2025 that may be closed by this pull request
feat: Allow omitting types in wgsl header when passed to the shell #1293
Closed
@aleksanderkatan aleksanderkatan changed the title Feat/allow omitting types in wgsl header feat: Allow omitting types in wgsl header May 27, 2025
@aleksanderkatan
Copy link
Contributor Author

Assumptions:

@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2025 •
edited
Loading

pkg.pr.new

packages

pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@1306
pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@315a4ccaad64ea9215119bf485231e42e89a8e1c

benchmark
view benchmark

commit
view commit

@aleksanderkatan aleksanderkatan marked this pull request as ready for review May 27, 2025 12:18
reczkok
reczkok approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@reczkok reczkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🧱

iwoplaza
iwoplaza requested changes Jun 4, 2025
View reviewed changes
@aleksanderkatan aleksanderkatan requested a review from iwoplaza June 5, 2025 08:28
iwoplaza
iwoplaza approved these changes Jun 5, 2025
View reviewed changes
Copy link
Collaborator

@iwoplaza iwoplaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the nits, amazing job!!

@aleksanderkatan aleksanderkatan merged commit 8ab8b13 into main Jun 6, 2025
6 checks passed
@aleksanderkatan aleksanderkatan deleted the feat/allow-omitting-types-in-wgsl-header branch June 6, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwoplaza iwoplaza iwoplaza approved these changes

@reczkok reczkok reczkok approved these changes

@mhawryluk mhawryluk Awaiting requested review from mhawryluk

@lursz lursz Awaiting requested review from lursz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Allow omitting types in wgsl header when passed to the shell
3 participants
@aleksanderkatan @iwoplaza @reczkok