Skip to content

feat: fish initial configuration #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
May 27, 2025
Merged

feat: fish initial configuration #1279

merged 25 commits into from
May 27, 2025

Conversation

lursz
Copy link
Contributor

@lursz lursz commented May 21, 2025 •
edited
Loading

image - Introduced loading screen for fishes - Introduced initial preset for fishes. - during loading fish speed up 3x in order to get into respective positions more quickly

@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2025 •
edited
Loading

pkg.pr.new

packages

pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@1279
pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@f4cc30998cefc30ebbf2fc8f6f1b9a3fd3ceeb18

benchmark
view benchmark

commit
view commit

@lursz lursz marked this pull request as ready for review May 21, 2025 14:57
aleksanderkatan
aleksanderkatan requested changes May 22, 2025
View reviewed changes
Copy link
Contributor

@aleksanderkatan aleksanderkatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great!

mhawryluk
mhawryluk reviewed May 27, 2025
View reviewed changes
mhawryluk
mhawryluk approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@mhawryluk mhawryluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!! 🐠

aleksanderkatan
aleksanderkatan reviewed May 27, 2025
View reviewed changes
Copy link
Contributor

@aleksanderkatan aleksanderkatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!!

aleksanderkatan
aleksanderkatan approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@aleksanderkatan aleksanderkatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge it

@lursz lursz merged commit 263c4e6 into release May 27, 2025
6 checks passed
@aleksanderkatan aleksanderkatan linked an issue May 28, 2025 that may be closed by this pull request
docs: Create more eye-pleasing initial condition for the 3D fish example #1084
Closed
@aleksanderkatan aleksanderkatan deleted the feat/fish_init branch June 6, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksanderkatan aleksanderkatan aleksanderkatan approved these changes

@mhawryluk mhawryluk mhawryluk approved these changes

@iwoplaza iwoplaza Awaiting requested review from iwoplaza

@reczkok reczkok Awaiting requested review from reczkok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: Create more eye-pleasing initial condition for the 3D fish example
3 participants
@lursz @aleksanderkatan @mhawryluk