Skip to content

impr: Add proper restrictions for Vertex stage builtins #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 27, 2025

Conversation

mhawryluk
Copy link
Contributor

closes #827

Copy link

github-actions bot commented May 19, 2025

pkg.pr.new

packages

pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@1259
pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@0f4fa8396c1d8950cbee77edfcc494fdba86418b

benchmark
view benchmark

commit
view commit

Copy link
Contributor

@reczkok reczkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 The errors are unfortunately not the most readable but I don't think we can do much about that at the moment.

Copy link
Collaborator

@iwoplaza iwoplaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome change! 👏

@mhawryluk mhawryluk merged commit b798e6a into main May 27, 2025
6 checks passed
@mhawryluk mhawryluk deleted the feat/vertex-builtin-restrictions branch May 27, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add proper restrictions for Vertex and Fragment stage builtins
3 participants