Skip to content

fix: Use a more compatible texture format for stable-fluids example and add touch controls #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025

Conversation

reczkok
Copy link
Contributor

@reczkok reczkok commented May 14, 2025

It seems safari on iOS (or at least the A15 Bionic) does not have the float32-filterable feature. Since the simulation will be just fine with a little less precision this PR moves all textures to rgba16float which is guaranteed to be both filterable and bindable as storage on all devices.

Copy link

github-actions bot commented May 14, 2025

pkg.pr.new

packages

pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@1251
pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@a0798beefb90684900859d908b984660f7ecb0a8

benchmark
view benchmark

commit
view commit

Copy link
Contributor

@aleksanderkatan aleksanderkatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💧

Copy link
Contributor

@mhawryluk mhawryluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌊

@reczkok reczkok changed the title fix: Use a more compatible texture format for stable-fluids example fix: Use a more compatible texture format for stable-fluids example and add touch controls May 15, 2025
@reczkok
Copy link
Contributor Author

reczkok commented May 15, 2025

Sorry for the re-review but i just realized there was no touch controls handling 🤦‍♂️

Copy link
Collaborator

@iwoplaza iwoplaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪼🪼🪼

@reczkok reczkok merged commit c5efd65 into release May 15, 2025
6 checks passed
@reczkok reczkok deleted the fix/stable-fluids-better-format branch May 15, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants