Skip to content

feat: Allow for...of statement to work with vectors and matrices #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 13, 2025
Merged

feat: Allow for...of statement to work with vectors and matrices #1226

merged 10 commits into from
May 13, 2025

Conversation

mhawryluk
Copy link
Contributor

closes #1106

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2025 •
edited
Loading

pkg.pr.new

packages

pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@1226
pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@46411fa817da2249f619ad409253269042d93fe4

benchmark
view benchmark

commit
view commit

aleksanderkatan
aleksanderkatan approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@aleksanderkatan aleksanderkatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/typegpu/src/data/matrix.ts Outdated
yield this[1];
yield this[2];
yield this[3];
return undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that return undefined is unnecessary, is there a reason for including this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without it the function's return type is void instead of undefined and there's a type error (not assignable to the property in base class)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind. that's only for vectors, cause they extend Array

@deluksic
Copy link
Contributor

deluksic commented May 9, 2025 •
edited
Loading

This will indeed work, just fyi the current implementation of vector already supports iteration due to it extending from Array. I believe the only issue was typescript. It should be possible to const [x, y] = vec2() and have x and y be number (not number | undefined). Which is what I tried to do by doing implements TupleN<S>, but it gets lost after going through vecN() constructor.

iwoplaza
iwoplaza approved these changes May 12, 2025
View reviewed changes
Copy link
Collaborator

@iwoplaza iwoplaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome change! 🚀

@mhawryluk mhawryluk changed the title feat: Implement [Symbol.iterator]() for vec instances feat: Allow for...of statement to work with vectors and matrices May 13, 2025
@mhawryluk mhawryluk merged commit eaa9ee4 into main May 13, 2025
6 checks passed
@mhawryluk mhawryluk deleted the feat/vector-for-of branch May 13, 2025 05:51
aleksanderkatan pushed a commit that referenced this pull request May 13, 2025
@mhawryluk
feat: Allow for...of statement to work with vectors and matrices (#1226)
1d4774d
iwoplaza added a commit that referenced this pull request May 13, 2025
@aleksanderkatan @lursz
@iwoplaza @mhawryluk
docs: Add Gravity example & ops: Use git lfs for large files (#1149)
632674c 
* Raster cube with lighting
Added dependencies, cube model, textures, directional and point lighting
* Moved cube code into separate file
* Comprehensive logic separation
* Added gravitational force
* Rewrote shader to apply gravitational force
* Central gravity

* Code reformatting and drag

* Moved necessary celestial bodies to gpu data holders

* Accessing celestialBodies in shader

* Compute shader modifications, celestialBodiesGroup changes

* Moved all calculations into compute shader

* Compute shader is now fully integrated

* Introduced matrix translation

* Introduced std identity

* Added tests for std.identity

* Tests updates

* Compute shader fixes

* Working compute shader implementation

* Compute shader works for multiple objects

* Working multiple celestial bodies

* Background colour to black

* Introduced newton gravity equation

* Sphere vertices

* 4th cube spawns

* Merge with origin/main

* Revert "Merge with origin/main"

This reverts commit 5e10b86.

* Refactor 1

* Refactor 2 - remove cube.ts

* Refactor 3 - rename files

* Refactor 4 - schemas.ts

* Refactor 5 - move matrix functions to another file

* Add buffer for other compute inputs

* Rewrite compute shader

* Move compute buffers to DynamicResources

* Add initial parameters loading from presets.ts

* Add preset switching

* Add depth stencil

* Fix compute bodies count

* Add lighting from 3D fish

* Add sphere model

* Add celestial body radius

* Merge fixes

* Update camera to newer version

* Make velocity and radius optional in presets.ts

* Add resizeObserver, make canvas fit to container

* Add skyboxes

* Move textures to gravity folder in assets

* Add custom celestial body texture support

* Change algorithm to leapfrog, fix transformation matrix issues

* Replace compute method with more accurate one

* Update celestial body bouncing

* Finish `Planet rings` preset

* Update `CelestialBody` schema

* Move enums to a dedicated folder

* Remove radius and transformation matrix from CelestialBody

* Split compute pipeline into two pipelines

* Implement merge collisions

* Remove celestialBodiesLayout from render

* Split compute layouts for different pipelines

* Add simulation speed slider

* Replace sphere model with an icosphere

* Refactor render bing groups

* Add attribution, dispose od old data

* Add mobile controls

* Remove matrix changes

* Remove test presets

* Add Solar System preset

* Add default camera positions to the presets

* Remove extra skyboxes, make Solar System the default preset

* Update lighting system

* Update preset light sources

* Remove babel dependency (why was it here to begin with?)

* Make simulation frame independent

* Merge load-models and textures into helpers.ts

* Nits

* Remove dev comment

* Make naming schema consistent

* Change `collisionBehaviors` from array to object

* Refactor collision logic

* Change skyBox to a static resource

* Inline device

* Add `initialPreset` variable

* Simplify arrow syntax where possible

* Remove cull mode

* Git LFS

* Treating .obj files as large files

* I don't know what changed

* Change mouseup event to be on window

* Add cullMode to render pipeline

* Update CI

* Reload github actions

* Apply deno formatting

* Remove `.does` from examples

* Try remove manual `git lfs pull`

* Apply suggestions from code review

Co-authored-by: Iwo Plaza <[email protected]>

* feat: Use accessor for OKLab alpha (#1228)

* feat: Use accessor for OKLab alpha
* Review fixes

* docs: unplugin-typegpu guide (#1191)

* docs: ColorPicker example controls (#1214)

* docs: Persist ControlPanel toggles state in local storage (#1222)

* fix: Small formatting fix in ColorPicker

* impr: Throw error when trying to define tgpu.derived during resolution (#1223)

* feat: Allow for...of statement to work with vectors and matrices (#1226)

* Undo formatting on index

* Update skybox vertexFn in examples

* Simplified skybox shader

* Simplified skybox in the reflection example

---------

Co-authored-by: lursz <[email protected]>
Co-authored-by: Aleksander Katan <[email protected]>
Co-authored-by: Iwo Plaza <[email protected]>
Co-authored-by: Marcin Hawryluk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwoplaza iwoplaza iwoplaza approved these changes

@aleksanderkatan aleksanderkatan aleksanderkatan approved these changes

@reczkok reczkok Awaiting requested review from reczkok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

impr: Implement [Symbol.iterator]() for vec instances
4 participants
@mhawryluk @deluksic @iwoplaza @aleksanderkatan