Skip to content

refactor: Using $internal symbol for storing internals in plain sight #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 25, 2025

Conversation

iwoplaza
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Apr 22, 2025

pkg.pr.new

packages

pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@1182
pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@0abccdfa3906af492d3271234c4ce78cbf0a0655

benchmark
view benchmark

commit
view commit

@iwoplaza iwoplaza marked this pull request as ready for review April 24, 2025 09:11
Copy link
Contributor

@mhawryluk mhawryluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🧹

Copy link
Contributor

@reczkok reczkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ⚙️🧹

@iwoplaza iwoplaza merged commit 7415eaf into main Apr 25, 2025
6 checks passed
@iwoplaza iwoplaza deleted the refactor/pipe-fn-symbol branch April 25, 2025 12:11
reczkok pushed a commit that referenced this pull request Apr 28, 2025
…#1182)

* refactor: Use internal symbol to identify TypeGPU-originating values

* Fixed dual impl internal types

* Smaller builtins

* refactor: Using $internal symbol for storing internals in plain sight

* More internal movement

* Sampled textures

* Better internals

* Verifying textures by internal prop

* Requiring compute and render pipelines to have internal prop

* Fixed imports

* Cleanup

* Even cleaner

* Prop order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants