Skip to content

fix(unplugin-typegpu): source-map misalignment when removing directives (& @ark/attest) #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 14, 2025
Merged

fix(unplugin-typegpu): source-map misalignment when removing directives (& @ark/attest) #1151

merged 13 commits into from
Apr 14, 2025

Conversation

iwoplaza
Copy link
Collaborator

@iwoplaza iwoplaza commented Apr 14, 2025 •
edited
Loading

Changes:

  • Updated to latest unplugin version
  • Making use of native filter functionality (better performance in some bundlers)
  • Fixed source-map misalignment by working on a copy of the AST before passing it to tinyest

@iwoplaza iwoplaza linked an issue Apr 14, 2025 that may be closed by this pull request
Incorporate @ark/attest into tests for checking if Schemas are inferred properly #935
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 14, 2025 •
edited
Loading

pkg.pr.new

packages

pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@1151
pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@0f8fa0dfba81a2645365e50e2a7fc9b16b7ec041

benchmark
view benchmark

commit
view commit

mhawryluk
mhawryluk approved these changes Apr 14, 2025
View reviewed changes
@iwoplaza iwoplaza merged commit ed94449 into main Apr 14, 2025
6 checks passed
@iwoplaza iwoplaza deleted the test/incorporate-arkattest-for-checking-infer branch April 14, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhawryluk mhawryluk mhawryluk approved these changes

@reczkok reczkok Awaiting requested review from reczkok

@aleksanderkatan aleksanderkatan Awaiting requested review from aleksanderkatan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorporate @ark/attest into tests for checking if Schemas are inferred properly
2 participants
@iwoplaza @mhawryluk