Skip to content

fix(typegpu-docs): Cross file import types #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2025
Merged

fix(typegpu-docs): Cross file import types #1142

merged 3 commits into from
Apr 14, 2025

Conversation

iwoplaza
Copy link
Collaborator

@iwoplaza iwoplaza commented Apr 9, 2025

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025 •
edited
Loading

pkg.pr.new

packages

pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@1142
pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@413714273f0e8e124bc47ee82b197f8ab379f0af

benchmark
view benchmark

commit
view commit

@iwoplaza iwoplaza linked an issue Apr 9, 2025 that may be closed by this pull request
fix(typegpu-docs): Cross-file imports in examples are not typed #1139
Closed
@iwoplaza iwoplaza marked this pull request as ready for review April 9, 2025 11:43
mhawryluk
mhawryluk approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@mhawryluk mhawryluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🐸

reczkok
reczkok approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@reczkok reczkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🧨

aleksanderkatan
aleksanderkatan reviewed Apr 10, 2025
View reviewed changes
@iwoplaza iwoplaza merged commit 33ef2e7 into release Apr 14, 2025
6 checks passed
@iwoplaza iwoplaza deleted the fix/cross-file-import-types branch April 14, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksanderkatan aleksanderkatan aleksanderkatan left review comments

@reczkok reczkok reczkok approved these changes

@mhawryluk mhawryluk mhawryluk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(typegpu-docs): Cross-file imports in examples are not typed
4 participants
@iwoplaza @aleksanderkatan @reczkok @mhawryluk