Skip to content

feat: layout.value #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 3, 2025
Merged

feat: layout.value #1098

merged 5 commits into from
Apr 3, 2025

Conversation

iwoplaza
Copy link
Collaborator

@iwoplaza iwoplaza commented Mar 29, 2025

Why?

To avoid double "unwrapping" of the layout entries, e.g., layout.bound.foo.value.

Copy link

github-actions bot commented Mar 29, 2025

pkg.pr.new

packages

pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@1098
pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@caeb2120639e6870bb077256f3e6480294ea3fff

benchmark
view benchmark

commit
view commit

@iwoplaza iwoplaza marked this pull request as ready for review March 31, 2025 10:35
@iwoplaza iwoplaza requested review from mhawryluk, aleksanderkatan and reczkok and removed request for mhawryluk and aleksanderkatan March 31, 2025 10:35
@iwoplaza iwoplaza requested a review from mhawryluk April 1, 2025 10:03
Copy link
Contributor

@reczkok reczkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Contributor

@mhawryluk mhawryluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 💵

@iwoplaza iwoplaza merged commit 59c4252 into main Apr 3, 2025
6 checks passed
@iwoplaza iwoplaza deleted the feat/layout-value branch April 3, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants