Skip to content

feat: array.length in TGSL #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 31, 2025
Merged

feat: array.length in TGSL #1097

merged 4 commits into from
Mar 31, 2025

Conversation

iwoplaza
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Mar 29, 2025

pkg.pr.new

packages

pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@1097
pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@867eeaef60c16ce57a4b6a49dfa0b99d0dab0fe6

benchmark
view benchmark

commit
view commit

@iwoplaza iwoplaza marked this pull request as ready for review March 31, 2025 10:07
@iwoplaza iwoplaza requested review from mhawryluk, reczkok and aleksanderkatan and removed request for mhawryluk March 31, 2025 10:08
Copy link
Contributor

@reczkok reczkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very convenient❣️I just hope once we start supporting some JS specific syntax users won't get confused what they can and can't use. I could see that being frustrating 😐

@iwoplaza
Copy link
Collaborator Author

Very convenient❣️I just hope once we start supporting some JS specific syntax users won't get confused what they can and can't use. I could see that being frustrating 😐

I can see that. It's definitely a balance. Perhaps with good error messaging, we can make these frustrations less... frustrating! We have a lot of context around the validity of code, and what syntax is supported, so we can strictly validate that only a subset of properties are accessible on values of datatype "WgslArray" or "Disarray", and throw a descriptive error otherwise.

@iwoplaza iwoplaza merged commit 459ee43 into main Mar 31, 2025
6 checks passed
@iwoplaza iwoplaza deleted the feat/array-dot-length branch March 31, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants