Upgrade dependencies, add debug logs

[roryabraham]

Hello 👋🏼

We love this action, but we saw some errors with it today. I forked the action and was able to fix it. I'm not sure exactly which of these changes resolved the error(s), but they all seem reasonably beneficial.

• Switch from Node 12 to Node 16
• Upgrade all dependencies to latest
• Fix some resultant TypeScript errors
• Add debug logs

[fbuinosquy1985]

Please merge and release it.

[roryabraham]

If you need this fix, you can use my fork in the meantime: https://github.com/roryabraham/turnstyle

[michaelstepner]

FYI @fbuinosquy1985 and @roryabraham:

Github has incorporated equivalent functionality to turnstyle into the Github Actions spec using the 'concurrency' parameter. softprops/turnstyle was developed in 2020 and Github added the concurrency parameter in 2021.

The native 'concurrency' implementation has additional features beyond what's possible in turnstyle, and it is lower cost: it leaves jobs pending rather than running while they wait for a previous job to end.

[fbuinosquy1985]

FYI @fbuinosquy1985 and @roryabraham:

Github has incorporated equivalent functionality to turnstyle into the Github Actions spec using the 'concurrency' parameter. softprops/turnstyle was developed in 2020 and Github added the concurrency parameter in 2021.

The native 'concurrency' implementation has additional features beyond what's possible in turnstyle, and it is lower cost: it leaves jobs pending rather than running while they wait for a previous job to end.

yes i know that, but i want to use this anyway

[michaelstepner]

yes i know that, but i want to use this anyway

👍, i expect some other people looking at this PR might not know this package duplicates now-native functionality, so hopefully my comment will be useful to others.

[dudicoco]

FYI @fbuinosquy1985 and @roryabraham:

Github has incorporated equivalent functionality to turnstyle into the Github Actions spec using the 'concurrency' parameter. softprops/turnstyle was developed in 2020 and Github added the concurrency parameter in 2021.

The native 'concurrency' implementation has additional features beyond what's possible in turnstyle, and it is lower cost: it leaves jobs pending rather than running while they wait for a previous job to end.

@michaelstepner that's incorrect, the native functionality only waits for one job to complete while this action acts as a queue waiting for all previous jobs to complete.

Per the docs:

When a concurrent job or workflow is queued, if another job or workflow using the same concurrency group in the repository is in progress, the queued job or workflow will be pending. Any previously pending job or workflow in the concurrency group will be canceled.

[michaelstepner]

the native functionality only waits for one job to complete while this action acts as a queue waiting for all previous jobs to complete.

Good point @dudicoco! It would be more accurate to say that concurrency is not a complete replacement for turnstyle:

• There are features in turnstyle not present in concurrency
• There are features in concurrency not present in turnstyle

[varunaroratest]

Hi @softprops
Please create a release with the latest changes.