feat: support project-specific additional parameters #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShawkyZ
reviewed
Dec 9, 2024
| @@ -13,8 +13,8 @@ | |||
| import io.snyk.languageserver.LsRuntimeEnvironment; | |||
|
|
|||
| public class Preferences { | |||
| static Preferences CURRENT_PREFERENCES; | |||
| static LsRuntimeEnvironment LS_RUNTIME_ENV = new LsRuntimeEnvironment(); | |||
| public static Preferences CURRENT_PREFERENCES; | |||
There was a problem hiding this comment.
double check why we need this as public
ShawkyZ
reviewed
Dec 9, 2024
| return param; | ||
| } | ||
|
|
||
| // returns null if nothing found |
ShawkyZ
reviewed
Dec 9, 2024
| public void addFolderConfig(FolderConfig folderConfig) { | ||
| instancePreferences.put(folderConfig.getFolderPath(), gson.toJson(folderConfig)); | ||
| try { | ||
| instancePreferences.flush(); |
ShawkyZ
reviewed
Dec 9, 2024
| } | ||
|
|
||
| public void addFolderConfig(FolderConfig folderConfig) { | ||
| instancePreferences.put(folderConfig.getFolderPath(), gson.toJson(folderConfig)); |
ShawkyZ
reviewed
Dec 9, 2024
|
|
||
| public void addAll(List<FolderConfig> folderConfigs) { | ||
| for (FolderConfig folderConfig : folderConfigs) { | ||
| addFolderConfig(folderConfig); |
There was a problem hiding this comment.
nitpick this will call persist for every entry. maybe we can batch them
ShawkyZ
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Screenshots / GIFs