-
Notifications
You must be signed in to change notification settings - Fork 8
feat: add ToS and privacy, remove old legacy view [IDE-810] [IDE-713] #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShawkyZ
reviewed
Dec 5, 2024
@@ -317,10 +321,6 @@ public void hasAuthenticated(HasAuthenticatedParam param) { | |||
refreshFeatureFlags(); | |||
} | |||
|
|||
if (!newToken.isBlank() && PlatformUI.isWorkbenchRunning()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should enable the new view actions here?
ShawkyZ
approved these changes
Dec 5, 2024
acke
pushed a commit
that referenced
this pull request
Dec 5, 2024
…#237) * feat: add ToS and privacy, remove old legacy view * chore: remove legacy view from plugin.xml * chore: update theme id for background colors
acke
added a commit
that referenced
this pull request
Dec 5, 2024
commit ba6787a Author: Bastian Doetsch <[email protected]> Date: Thu Dec 5 09:50:25 2024 +0100 feat: add ToS and privacy, remove old legacy view [IDE-810] [IDE-713] (#237) * feat: add ToS and privacy, remove old legacy view * chore: remove legacy view from plugin.xml * chore: update theme id for background colors Merge branch 'main' into feat/IDE-739_branch_selection_node
acke
added a commit
that referenced
this pull request
Dec 5, 2024
commit ba6787a Author: Bastian Doetsch <[email protected]> Date: Thu Dec 5 09:50:25 2024 +0100 feat: add ToS and privacy, remove old legacy view [IDE-810] [IDE-713] (#237) * feat: add ToS and privacy, remove old legacy view * chore: remove legacy view from plugin.xml * chore: update theme id for background colors Merge branch 'main' into feat/IDE-739_branch_selection_node
acke
added a commit
that referenced
this pull request
Dec 5, 2024
commit ba6787a Author: Bastian Doetsch <[email protected]> Date: Thu Dec 5 09:50:25 2024 +0100 feat: add ToS and privacy, remove old legacy view [IDE-810] [IDE-713] (#237) * feat: add ToS and privacy, remove old legacy view * chore: remove legacy view from plugin.xml * chore: update theme id for background colors Merge branch 'main' into feat/IDE-739_branch_selection_node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Screenshots / GIFs