Skip to content

feat: add ToS and privacy, remove old legacy view [IDE-810] [IDE-713] #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

bastiandoetsch
Copy link
Contributor

Description

  • removes legacy view
  • adds ToS & Privacy link to welcome screen

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

image

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner December 5, 2024 07:13
@@ -317,10 +321,6 @@ public void hasAuthenticated(HasAuthenticatedParam param) {
refreshFeatureFlags();
}

if (!newToken.isBlank() && PlatformUI.isWorkbenchRunning()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should enable the new view actions here?

@bastiandoetsch bastiandoetsch enabled auto-merge (squash) December 5, 2024 08:49
@bastiandoetsch bastiandoetsch merged commit ba6787a into main Dec 5, 2024
7 checks passed
@bastiandoetsch bastiandoetsch deleted the feat/IDE-810_add-tos branch December 5, 2024 08:50
acke pushed a commit that referenced this pull request Dec 5, 2024
…#237)

* feat: add ToS and privacy, remove old legacy view

* chore: remove legacy view from plugin.xml

* chore: update theme id for background colors
acke added a commit that referenced this pull request Dec 5, 2024
commit ba6787a
Author: Bastian Doetsch <[email protected]>
Date:   Thu Dec 5 09:50:25 2024 +0100

    feat: add ToS and privacy, remove old legacy view [IDE-810] [IDE-713] (#237)

    * feat: add ToS and privacy, remove old legacy view

    * chore: remove legacy view from plugin.xml

    * chore: update theme id for background colors
Merge branch 'main' into feat/IDE-739_branch_selection_node
acke added a commit that referenced this pull request Dec 5, 2024
commit ba6787a
Author: Bastian Doetsch <[email protected]>
Date:   Thu Dec 5 09:50:25 2024 +0100

    feat: add ToS and privacy, remove old legacy view [IDE-810] [IDE-713] (#237)

    * feat: add ToS and privacy, remove old legacy view

    * chore: remove legacy view from plugin.xml

    * chore: update theme id for background colors
Merge branch 'main' into feat/IDE-739_branch_selection_node
acke added a commit that referenced this pull request Dec 5, 2024
commit ba6787a
Author: Bastian Doetsch <[email protected]>
Date:   Thu Dec 5 09:50:25 2024 +0100

    feat: add ToS and privacy, remove old legacy view [IDE-810] [IDE-713] (#237)

    * feat: add ToS and privacy, remove old legacy view

    * chore: remove legacy view from plugin.xml

    * chore: update theme id for background colors
Merge branch 'main' into feat/IDE-739_branch_selection_node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants