Feat/ide 715 filter tree #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m-IaC,-Open-Source-and-Code,-using-a-local-cache (#215) * chore: wip * fix: add info nodes for no issues found and no fixable issues found * fix: tests * feat: add initial tree filling impl * feat: display info nodes * feat: add generic filter method to cache * feat: show view when scanning
…s/expand treeviewer.
fix: tests on command line
* feat: prepending the treenodes for ignores and AI Fix with identifier * fix: added space after ignore tag * feat: add a call to read feature flags, and call that function to read snykCodeConsistentIgnores * fix: expand treeviewer to show all issues. * fix: wip remvoe ignores filters if needed * fix: rename file * fix: call featureflag service after auth and settings persistence * fix: notifyProgress if param is null * feat: taskprocessor for sending tasks after ls init * fix: tests use current pref * feat: filter issues based on ignore preferences * fix: remove commands if ff for ignores are false * fix: adding the handlers and commands for filters * fix: adding an asyncExec on the ui updates --------- Co-authored-by: Abdelrahman Shawki Hassan <[email protected]>
* wip: html provider * fix: populate tree after snyk.Scan success * refactor: use css from LS * wip: html provider * fix: merge conflicts * fix: added HtmlProviderFactory tests * fix: use comperator for sorting issues * refactor: create BrowserHandler * fix: cache theme instance
Co-authored-by: Abdelrahman Shawki Hassan <[email protected]>
acke
force-pushed
the
feat/IDE-715_filter-tree
branch
from
17800d7 to
ef58e01
Compare
ShawkyZ
reviewed
Nov 26, 2024
| private boolean isIssueVisible(IssueTreeNode issueNode) { | ||
| Issue issue = issueNode.getIssue(); | ||
| if (issue == null) { | ||
| return true; |
There was a problem hiding this comment.
why would it be visible if null?
There was a problem hiding this comment.
We don't want to apply filters (and hide) tree elements if we don't match any filters.
ShawkyZ
reviewed
Nov 26, 2024
| @Override | ||
| public boolean select(Viewer viewer, Object parentElement, Object element) { | ||
| if (element instanceof FileTreeNode) { | ||
| return hasVisibleChildren((FileTreeNode) element, viewer); |
There was a problem hiding this comment.
that looks good. I hope it wouldn't be a performance bottleneck tho.
There was a problem hiding this comment.
Agreed, we only call the hasVisibleChildren if the node is a treenode, so its not called for all tree nodes. However this might be slow if a project has very many files.
ShawkyZ
reviewed
Nov 26, 2024
.../src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/filters/SeverityCriticalFilter.java
Show resolved
Hide resolved
ShawkyZ
approved these changes
Nov 26, 2024
acke
force-pushed
the
feat/IDE-715_filter-tree
branch
from
db1aad9 to
a95df80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The file tree can now use the viewmenus popup menu to select these filters:
Additional work on filters will be done in this ticket
https://snyksec.atlassian.net/browse/IDE-782?atlOrigin=eyJpIjoiOGZhM2IzMjlkYzAyNDI4Njg1MWRkZDZiMDM1MGRlMTgiLCJwIjoiaiJ9
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!