feat: create a new snyk view [IDE-711][IDE-712][IDE-713] #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acke
force-pushed
the
feat/IDE-711_create_a_new_snyk_view
branch
from
9083c23 to
e31bd11
Compare
acke
force-pushed
the
feat/IDE-711_create_a_new_snyk_view
branch
from
e21aa41 to
07ecfa0
Compare
acke
force-pushed
the
feat/IDE-711_create_a_new_snyk_view
branch
from
07ecfa0 to
5fc6f71
Compare
| try { | ||
| boolean cliFound = getCliFile().exists(); | ||
| boolean tokenFound = !Preferences.getInstance().getAuthToken().isBlank() | ||
| || System.getenv().containsKey("SNYK_TOKEN"); |
There was a problem hiding this comment.
The SNYK_TOKEN check is old and a bug :)
There was a problem hiding this comment.
Should we remove tokenFound, or only the System.getenv().containsKey check?
plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/RootObject.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/RootObject.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/snyk/eclipse/plugin/views/snyktoolview/handlers/EnableCodeProductHandler.java
Outdated
Show resolved
Hide resolved
acke
force-pushed
the
feat/IDE-711_create_a_new_snyk_view
branch
from
27789d2 to
e027045
Compare
...c/main/java/io/snyk/eclipse/plugin/views/snyktoolview/handlers/EnableCodeProductHandler.java
Outdated
Show resolved
Hide resolved
acke
force-pushed
the
feat/IDE-711_create_a_new_snyk_view
branch
from
def77c5 to
8d3a3c0
Compare
chore: UI cleanup [IDE-711 ]
Feat/fixable issues filter
* feat: add project level * fix: tests * feat: add file & issue nodes (wip) * feat: add issue navigation * fix: add missing icons * fix: node filtering * fix: create custom publishDiagnostic for faster deserilization * fix: use Webview2 browser on Windows * chore: added comment * wip: cancel all scans * tidy: clean up unused things * fix: clean up tree when scan is cancelled * fix: expand treenodes after product nodes are added to tree * fix: added unit tests for progressmanager * fix: indentation * fix: dont run progress cancellation in UI --------- Co-authored-by: Knut Funkel <[email protected]> Co-authored-by: Abdelrahman Shawki Hassan <[email protected]>
fix: tests on command line
* feat: prepending the treenodes for ignores and AI Fix with identifier * fix: added space after ignore tag * feat: add a call to read feature flags, and call that function to read snykCodeConsistentIgnores * fix: expand treeviewer to show all issues. * fix: wip remvoe ignores filters if needed * fix: rename file * fix: call featureflag service after auth and settings persistence * fix: notifyProgress if param is null * feat: taskprocessor for sending tasks after ls init * fix: tests use current pref * feat: filter issues based on ignore preferences * fix: remove commands if ff for ignores are false * fix: adding the handlers and commands for filters * fix: adding an asyncExec on the ui updates --------- Co-authored-by: Abdelrahman Shawki Hassan <[email protected]>
* wip: html provider * fix: populate tree after snyk.Scan success * refactor: use css from LS * wip: html provider * fix: merge conflicts * fix: added HtmlProviderFactory tests * fix: use comperator for sorting issues * refactor: create BrowserHandler * fix: cache theme instance
bastiandoetsch
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!