Skip to content

feat: get Issues from LS #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 12, 2024
Merged

feat: get Issues from LS #212

merged 15 commits into from
Nov 12, 2024

Conversation

ShawkyZ
Copy link
Contributor

@ShawkyZ ShawkyZ commented Nov 8, 2024 •
edited
Loading

Description

  • publishDiagnostics handler
  • snyk.Scan handler
  • generateIssueDescription command

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@ShawkyZ ShawkyZ changed the title wip: publishDiagnostics notification handler feat: get Issues from LS Nov 11, 2024
@ShawkyZ ShawkyZ marked this pull request as ready for review November 11, 2024 12:40
@ShawkyZ ShawkyZ requested a review from a team as a code owner November 11, 2024 12:40
@ShawkyZ ShawkyZ enabled auto-merge (squash) November 11, 2024 14:22
bastiandoetsch
bastiandoetsch reviewed Nov 11, 2024
View reviewed changes
plugin/src/main/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClient.java Outdated

private String lspSourceToProduct(String source) {
switch(source) {
case "Snyk Code":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: same here, these could all be constants

bastiandoetsch
bastiandoetsch reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@bastiandoetsch bastiandoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all the data classes, having a sensible toString(), equals and hashCode method would be awesome.

@ShawkyZ ShawkyZ disabled auto-merge November 11, 2024 16:26
@ShawkyZ ShawkyZ enabled auto-merge (squash) November 12, 2024 08:29
@ShawkyZ ShawkyZ merged commit 42da586 into main Nov 12, 2024
7 checks passed
@ShawkyZ ShawkyZ deleted the feat/results-from-publishDiagnostics branch November 12, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastiandoetsch bastiandoetsch bastiandoetsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShawkyZ @bastiandoetsch