Skip to content

fix: dont sign build on PR checks #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 7, 2024
Merged

fix: dont sign build on PR checks #205

merged 3 commits into from
Oct 7, 2024

Conversation

bastiandoetsch
Copy link
Contributor

Description

  • update workflow to only sign builds on main.
  • updated jackson binaries to 2.15.0 to mitigate security issue

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner October 7, 2024 06:41
@bastiandoetsch bastiandoetsch mentioned this pull request Oct 7, 2024
Merged
4 tasks
@ShawkyZ ShawkyZ merged commit afe69d7 into main Oct 7, 2024
7 checks passed
@ShawkyZ ShawkyZ deleted the fix/dont-use-keystore-in-pr-checks branch October 7, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShawkyZ ShawkyZ ShawkyZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastiandoetsch @ShawkyZ