Skip to content

feat: update required protocol version to 12 [IDE-426] [IDE-376] #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bastiandoetsch
Copy link
Contributor

Description

Increases the required protocol version to 12, and also adds it to the LS initialization.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner June 27, 2024 10:08
@bastiandoetsch bastiandoetsch enabled auto-merge (squash) June 27, 2024 10:10
Copy link
Contributor

@acke acke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little question and the PR looks fine to me!


**Signing Information for Jars**
Snyk plugins are not supported on any operating system that has reached End Of Life (EOL) with the distributor. 
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a space here?

@bastiandoetsch bastiandoetsch merged commit abe3256 into main Jun 27, 2024
7 checks passed
@bastiandoetsch bastiandoetsch deleted the feat/IDE-376_update-required-protocol-version-to-12 branch June 27, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants