fix: don't use quotes when generating ignore #184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Eclipse has functionality to generate ignores using the
.snyk
ignore file. At the moment, this works but the generated ignores is not being taken into account when running a scan. This is because of extra quotes that get added incorrectly to the ignore rule.This PR removes the unnecessary quote when running the
snyk ignore
command.When using the CLI this is how I generate ignores:
snyk ignore --id=SNYK-JS-MARKED-2342073
Checklist
Screenshots
I used https://github.com/snyk-labs/nodejs-goof to test.
There are 120 vulns without the ignore so I applied an ignore (I already had the one I tested earlier):

After the ignore was generated we don't get the ignored vuln showing up (there are 111 vulns):

Matches what the CLI returns too:

note I did have to restart the sandbox because it wouldn't recognise
$snyk.scan
notifications anymore but I don't think it's because of this change: