feat: support cyclic graph #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
admons
force-pushed
the
feat/support-cyclic-graph5
branch
from
0a0d7c7 to
5cb6ff4
Compare
admons
commented
Mar 11, 2021
src/legacy/cycles.ts
Outdated
| nodeId: NodeId, | ||
| allCyclesTheNodeIsPartOf: Cycle[], | ||
| ): PartitionedCycles { | ||
| const cyclesStartWithThisNode = allCyclesTheNodeIsPartOf.filter( |
admons
commented
Mar 11, 2021
darscan
approved these changes
Mar 11, 2021
admons
force-pushed
the
feat/support-cyclic-graph5
branch
from
5cb6ff4 to
d1a2d07
Compare
This pr will add support for converting a cyclic graph into a tree Image example: convert `cyclic-complex-dep-graph.png` into `cyclic-complex-dep-graph-expected-optimized-tree.png`
admons
force-pushed
the
feat/support-cyclic-graph5
branch
from
d1a2d07 to
5705237
Compare
|
🎉 This PR is included in version 1.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It allows converting a cyclic graph into an optimized pruned dep-tree
For example, it will take the following DepGraph
And convert it into the following DepTree
The difference between this PR and #48 is the use of memoization for creating an optimized tree instead of duplicating all cyclic nodes