fix: validation logic of cocoapods purls #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darscan
approved these changes
Aug 29, 2023
mcombuechen
force-pushed
the
fix/validate-cocoapods-purl
branch
from
45464c3 to
87159ad
Compare
|
🎉 This PR is included in version 2.7.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds another case for the validation of
cocoapodspurls. CocoaPods purls encode the spec name as package name, and put the optional sub-spec on the subpath component; as opposed to the DepGraph which will encode spec name and subspec in a single, slash-divided string.E.g.
See specification for
cocoapodspurls here: https://github.com/package-url/purl-spec/blob/master/PURL-TYPES.rst#cocoapods.Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Screenshots
Additional questions