Skip to content
This repository was archived by the owner on Feb 1, 2023. It is now read-only.

refactor: allow injection of retrofit client in API implementation, r… #43

Merged
merged 3 commits into from
Jan 26, 2023

Conversation

bastiandoetsch
Copy link
Collaborator

@bastiandoetsch bastiandoetsch commented Jan 25, 2023

  • allow injection of retrofit client
  • remove setBaseURL method from API
  • update to gradle 7.6

The majority of the changes are (automatically generated) gradle updates, so the review is much easier, if you just ignore the gradlew and gradlew.bat files.

@bastiandoetsch bastiandoetsch marked this pull request as ready for review January 25, 2023 16:17
@bastiandoetsch bastiandoetsch requested a review from a team as a code owner January 25, 2023 16:17
Copy link
Contributor

@michelkaporin michelkaporin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely ❤️

@bastiandoetsch bastiandoetsch merged commit cc88a16 into master Jan 26, 2023
@bastiandoetsch bastiandoetsch deleted the refactor/client-injection branch January 26, 2023 10:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants