This repository was archived by the owner on Feb 1, 2023. It is now read-only.
feat: provide analysisContext key (getAnalysis request) for better tracking/logging on backend [ROAD-742]
#35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtsiomCh
force-pushed
the
feat/ROAD-742_analysisContext_for_getAnlysis
branch
from
1389241 to
67285b3
Compare
…r tracking/logging on backend
ArtsiomCh
force-pushed
the
feat/ROAD-742_analysisContext_for_getAnlysis
branch
from
67285b3 to
c6fcc90
Compare
pavel-snyk
reviewed
Mar 28, 2022
| @@ -22,17 +25,25 @@ public GetAnalysisRequest( | |||
| List<String> limitToFiles, | |||
| Integer severity, | |||
| String shard, | |||
| boolean prioritized, | |||
| String ideProductName, String orgDisplayName, boolean prioritized, | |||
There was a problem hiding this comment.
nitpick: maybe keep formatting consistent and have a line break between parameters.
pavel-snyk
approved these changes
Mar 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! Should/Could be reviewed/merged only after #33 merged and rebased !!!done